[CHA-2758] Add tests for future channel bans without channel CID#247
Closed
nijeesh-stream wants to merge 1 commit intomainfrom
Closed
[CHA-2758] Add tests for future channel bans without channel CID#247nijeesh-stream wants to merge 1 commit intomainfrom
nijeesh-stream wants to merge 1 commit intomainfrom
Conversation
Add integration tests covering the new backend capability (chat PR #12582) that allows ban_from_future_channels without requiring a channel_cid. Tests added: - Basic FCB creation without channel CID - Auto-ban applied to new channels created by the banner - Shadow ban preservation on FCB without CID - Full lifecycle: create and remove FCB without CID - Timeout/expiration preserved on FCB without CID Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Summary
ban_from_future_channelswithout requiring achannel_cidTests added
whenBanFromFutureChannelsWithoutChannelCid_thenSucceedschannel_cid, verifies record viaqueryFutureChannelBans, asserts user is NOT globally bannedwhenBanFromFutureChannelsWithoutCid_thenAutoAppliedToNewChannelswhenBanFromFutureChannelsWithoutCidAndShadow_thenPreservesShadowshadow=trueis preserved on the FCB recordwhenRemovingFutureChannelBanWithoutCid_thenBanIsRemovedunban().removeFutureChannelsBan(true).createdBy(), verify removedwhenBanFromFutureChannelsWithoutCidAndTimeout_thenExpirationSettimeout(60), verifiesexpiresfield is setChecklist
Made with Cursor